-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate bad function plugin arg #9736
Merged
multimokia
merged 5 commits into
Monika-After-Story:content
from
Booplicate:deprecate-bad-fp-args
Jun 18, 2023
Merged
Deprecate bad function plugin arg #9736
multimokia
merged 5 commits into
Monika-After-Story:content
from
Booplicate:deprecate-bad-fp-args
Jun 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutable args are bad `functools.partial` exists and provides a more clear way to give both args and kwargs to callables
Booplicate
added
awaiting testing
code needs to be tested
DONT MERGE
srs
awaiting code review
someone needs to check for syntax/logic/indentation errors
high priority
labels
Nov 12, 2022
for these, make it |
Co-Authored-By: ThePotatoGuy <potato@desu.zone>
multimokia
previously approved these changes
Jun 11, 2023
multimokia
reviewed
Jun 14, 2023
multimokia
previously approved these changes
Jun 15, 2023
Legendkiller21
approved these changes
Jun 17, 2023
multimokia
approved these changes
Jun 18, 2023
multimokia
removed
awaiting testing
code needs to be tested
awaiting code review
someone needs to check for syntax/logic/indentation errors
labels
Jun 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is waiting for #9725, do not merge until then, it uses the new deprecation API.
Originally planned to remove this with r8, but I think it will be better if we give time and properly deprecate this parameter now.
Changes:
_args
/args
parameter from[]
toNone
(which then being set to an emptytuple
). Mutable def arguments can cause bugsfunctionplugin
registerFunction
setArgs
setArgs
is now deprecatedgetArgs
is now deprecatedTesting:
setArgs
function