Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Path type in IAM resources to be Token[String] #149

Merged
merged 1 commit into from
Apr 19, 2017
Merged

Change Path type in IAM resources to be Token[String] #149

merged 1 commit into from
Apr 19, 2017

Conversation

jfklingler
Copy link
Contributor

@jfklingler jfklingler commented Mar 20, 2017

Fixes #148

This may warrant a minor version bump. The implicit conversion from String to Token[String] should take care of InstanceProfile. Since there's also an implicit conversion from T to Option[T], if people did not explicitly specify the Path in ManagedPolicy as Some("blah"), compilation will fail since only one implicit conversion will be applied.

@bkrodgers
Copy link
Contributor

I guess we could add an implicit conversion for Option[String] to Option[Token[String]] to make that backwards compatible. Thoughts?

@jfklingler
Copy link
Contributor Author

jfklingler commented Mar 31, 2017

I don't think that will help. If Path = "blah", we'd need an T => Option[Token[T]] implicit conversion. I can try that, but there are already quite a few implicit conversions floating around. I suppose we could make a more specific String => Option[Token[String]] IC, but that seems like overkill in the name of backward compatibility for a relatively simple and probably obvious change.

@bkrodgers
Copy link
Contributor

Since it was already an Option[String], hopefully most people were specifying it as Some("string") already. In that case, the current implicits should pick it up, right? It's only if they were relying on the implicit from String -> Option[String] that it'd break?

@jfklingler
Copy link
Contributor Author

That's correct.

@bkrodgers bkrodgers merged commit ea8558c into Bayer-Group:master Apr 19, 2017
@jfklingler jfklingler deleted the monsantoco-148 branch April 19, 2017 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants