Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the MCprep Optimizer #541

Closed
StandingPadAnimations opened this issue Feb 11, 2024 · 1 comment · Fixed by #543
Closed

Removing the MCprep Optimizer #541

StandingPadAnimations opened this issue Feb 11, 2024 · 1 comment · Fixed by #543
Labels
enhancement Feature requests or new functionality suggestions
Milestone

Comments

@StandingPadAnimations
Copy link
Collaborator

(mostly copied from #514 (comment))

MCprep 3.6 will remove the Cycles optimizer for the following reasons:

  • Hasn't caught up with latest Cycles developments
  • Algorithm is extremely buggy at times; there's been cases of it setting max bounces to values like 80. Ironically, I don't even use the optimizer (despite making it) for this very reason, and opt to manually optimize my scene
  • Better tools exist for automatic optimization; the Super Image Denoiser devs at Pidgeon Tools have SFR, a Cycles optimizer that actually profiles the scene, making it far better then what we have.
  • While the intent of the MCprep optimizer was to have something tuned specifically for Minecraft animation, I feel that over time, that became "how do we optimize a scene while not profiling, due to the average user's hardware?"
@StandingPadAnimations StandingPadAnimations added this to the v3.6.0 milestone Feb 11, 2024
@StandingPadAnimations StandingPadAnimations added the enhancement Feature requests or new functionality suggestions label Feb 11, 2024
@StandingPadAnimations StandingPadAnimations linked a pull request Feb 12, 2024 that will close this issue
@TheDuckCow
Copy link
Member

Marking this as closed, since the milestone branch has been completed. Will take effect in the next v3.6.0 release

@github-project-automation github-project-automation bot moved this from Todo to Done in MCprep Dev Team Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or new functionality suggestions
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants