Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Modify the scrolling control volume direction #89

Closed
WhoChangedMyCode opened this issue Nov 24, 2023 · 3 comments
Closed

Suggestion: Modify the scrolling control volume direction #89

WhoChangedMyCode opened this issue Nov 24, 2023 · 3 comments

Comments

@WhoChangedMyCode
Copy link

In the "Controls" of the "Scroll up/down", the current situation is that scrolling up is to lower the volume, scrolling down is to raise the volume, I think this is not in line with the intuitive operation, especially when I use the touchpad of the notebook, the result of the volume control is always the reverse of my first intuitive operation, maybe I am a different kind of bar.

I hope to have some improvement:
Scrolling up is to increase the volume, scrolling down is to decrease the volume. Or add a new option for the user to choose whether scrolling up raises the volume or lowers it.

@Moon-0xff
Copy link
Owner

I also noticed the touchpad gesture to raise/lower volume is reversed. But this is consistent with the global volume widget, and I think the rest of GNOME.

It's a simple change to add though, on extension.js:

			case 'volume-up':
				this._changeVolume(1); /* CHANGE THIS TO -1 */
				break;
			case 'volume-down':
				this._changeVolume(-1); /* CHANGE THIS TO 1 */
				break;
			case 'volume-mute':
				this._changeVolume(0);
				break;
		}
	}

	_changeVolume(delta){ /* MULTIPLY delta BY -1 */
		let stream = [];
		stream[0] = this.volumeControl.get_default_sink();
		let streamName = 'System Volume (Global)';

		const CONTROL_SCHEME = this.settings.get_string('volume-control-scheme');

@Batwam
Copy link
Collaborator

Batwam commented Dec 9, 2023

agreed with keeping the scroll volume control consistent between the extension and the global volume widget. I just checked and changed the setting from "Traditional" to "Natural"; they both inverted so that's the correct behaviour in my view.

@Moon-0xff
Copy link
Owner

Alright. I will close this as unplanned.

As mentioned: You can modify the source code to do this (just follow the comments I left on my previous comment).

@Moon-0xff Moon-0xff closed this as not planned Won't fix, can't repro, duplicate, stale Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants