You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I defined a codec provider that extends PropertyCodecProvider and define in manifest and module info the service i'm implementing so that MorphiaCodecProvider will load it using the ServiceLoader mechanism of java, but id didnt work.
Expected behavior
any codec provider defined properly using the serviceloader mechanism will be loaded
Server Version: 6
Driver Version:4.7.2
Morphia Version:2.3.0
I created a pull request to fix this issue: #2190 and map the property codec providers through mapper options like the regular codec providers are mapped
The text was updated successfully, but these errors were encountered:
So I've been playing with your PR a bit the last couple of days and have run in to a few issues. The most pressing is that it breaks the kotlin module which uses SPI for a couple of things. I've put together a reproducer that uses modules and I can definitely seen things break with a module-info.java where they work without out. However if I add the following line to my module def it seems to pick up the new codec just fine:
In 3.0, I'm thinking this will all be done via annotations at build time so there will be discovery at runtime either way. So the less I do now with this, the less there will be to unwind in the next version.
I defined a codec provider that extends PropertyCodecProvider and define in manifest and module info the service i'm implementing so that MorphiaCodecProvider will load it using the ServiceLoader mechanism of java, but id didnt work.
To Reproduce
https://github.com/daniel-exceed/property-codec-service-loader
Expected behavior
any codec provider defined properly using the serviceloader mechanism will be loaded
I created a pull request to fix this issue: #2190 and map the property codec providers through mapper options like the regular codec providers are mapped
The text was updated successfully, but these errors were encountered: