Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate password function #36

Open
patanric opened this issue Jul 4, 2017 · 4 comments
Open

Generate password function #36

patanric opened this issue Jul 4, 2017 · 4 comments

Comments

@patanric
Copy link
Contributor

patanric commented Jul 4, 2017

Implement a method that generates a password when the button in the NewLogin window is clicked. A simple password is ok. More sophisticated passwords could be done in a second step.

@samsam1414
Copy link

Hi Riccardo! I'm interested in helping this project (very new to open source). I've taken a stab at this open issue and I'm curious if it's a good fit for the project.

One small issue though: when I click Generate, a new password is generated and populates in its associated field. But as you can see below, the password shows up as dots:

passwordfield

My thoughts are that this field should be changed from the PasswordField class to the standard TextField class. Maybe this would then allow the end user to copy the generated password and paste it into the website registration form he/she is filling out.

@patanric
Copy link
Contributor Author

@bighandsam, welcome! :-)
Yes, in my opinion we should go ahead with whatever improvement we think is appropriate. I like your solution.

@sudk97
Copy link

sudk97 commented Aug 5, 2017

As @bighandsam suggested for displaying the password generated, I have added an extra checkbox that allows the user to toggle between show/hide password. Also, after reviewing the earlier contributors' work, I have written a much shorter version of password generator that works somewhat similar.
Please go through my code, and suggest any changes. Thank you.
screenshot

@jasm123
Copy link

jasm123 commented Oct 26, 2017

Hi,
Is this issue still open or closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants