Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Islamic dates changing at midnight not magrib time #17

Open
DilwoarH opened this issue Mar 6, 2019 · 0 comments
Open

Islamic dates changing at midnight not magrib time #17

DilwoarH opened this issue Mar 6, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@DilwoarH
Copy link
Collaborator

DilwoarH commented Mar 6, 2019

Describe the bug
Hi. I noticed the Islamic date is changing over at midnight; however, this should happen at the start of Maghrib. The way we do this in Excel is instead of using the date for NOW(), we add on the time between Maghrib and midnight, i.e,. NOW()+(12-Maghrib) [for 12-hour time format]. This is something people are more likely to notice in Ramadan! 🙂

Expected behavior
Date should change at beginning of magrib.

@DilwoarH DilwoarH added the bug Something isn't working label Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Need to discuss
Development

No branches or pull requests

1 participant