Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GitHub Sort Reactions) Suggestion: collapse out of view the block of buttons when mouseaway. In such case, display the active sort icon next to the two-triangles icon #39

Closed
darkred opened this issue Feb 28, 2018 · 4 comments

Comments

@darkred
Copy link
Collaborator

darkred commented Feb 28, 2018

@Mottie First of all, thanks a lot for this great script!
I was wondering whether it's possible to make a script to sort the comments based on the reactions in a practical way ! You really nailed it, once again! 👏


I just have one suggestion, please:

Currently, having two rows of button blocks (one of the post itself and the second by the script)
makes it distracting and difficult for me to visually distinguish them.

My suggestion is to collapse out of view (- in a similar way to that of your script "GitHub Reveal Header"- maybe collapse the block by temporarily converting it to a thin line/separator) the block of buttons on mouseaway from that element. And:

  • when a sort button is active and the block of buttons is collapsed on mouseaway,
    to display the currently active sort icon and its order (i.e. create an extra icon) next to the two-triangles icon.
  • when no sort is active, remove that extra icon.

Please see my mockup below to better see what I mean.

I know the script in it's initial version - I just wanted to post my suggestion and I hope you like it. 🙂

Example screenshot:
2018-02-28_193405
And a mockup:
2018-02-28_194332

PS. I've tried implementing my suggestion myself but unfortunately it seems too difficult for me, that's why I didn't provide a PR instead.

@darkred darkred changed the title (GitHub Sort Reactions) Suggestion: collapse out of view the block of buttons when mouseaway + display the active sort and its order next to the the two-triangles symbol (GitHub Sort Reactions) Suggestion: collapse out of view the block of buttons when mouseaway. In such case, display the active sort icon next to the two-triangles icon Feb 28, 2018
@Mottie
Copy link
Owner

Mottie commented Feb 28, 2018

Hi @darkred!

Yeah, I agree that having the bar under the comment with all the reactions is a bit confusing. Too many emojis clumped together!

I'm not sure I want to make the bar collapsible. Maybe instead we could do something like this?

Clicking the emoji would open a popup showing all reactions. Clicking the arrow would change the sort direction, or remove the sort on the third click.

@darkred
Copy link
Collaborator Author

darkred commented Feb 28, 2018

Great idea, @Mottie! That would be the best! Compact and subtle.

@Mottie Mottie closed this as completed in 2a68336 Mar 6, 2018
@Mottie
Copy link
Owner

Mottie commented Mar 6, 2018

Try this out:

@darkred
Copy link
Collaborator Author

darkred commented Mar 6, 2018

Great! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants