Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency and GUI updates #958

Merged
merged 6 commits into from
May 12, 2023
Merged

Dependency and GUI updates #958

merged 6 commits into from
May 12, 2023

Conversation

chriski777
Copy link
Collaborator

Fixes GUI issues mentioned in:

Fixes dependency issues with latest version of numpy and np.bool:

bin_frames has also been patched to accommodate cases in which current batch has fewer frames than bin_size:

@chriski777
Copy link
Collaborator Author

Test failures seem to be from the latest numpy version (1.24.3)... Seems Vmat needs to be saved as an object type np.ndarray or else scipy.io.savemat fails

@codecov-commenter
Copy link

Codecov Report

Merging #958 (4d9dd2b) into main (f8d2c28) will increase coverage by 0.00%.
The diff coverage is 53.84%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #958   +/-   ##
=======================================
  Coverage   27.64%   27.64%           
=======================================
  Files          56       56           
  Lines        9971     9973    +2     
=======================================
+ Hits         2756     2757    +1     
- Misses       7215     7216    +1     
Impacted Files Coverage Δ
suite2p/detection/sparsedetect.py 94.40% <ø> (ø)
suite2p/gui/drawroi.py 0.00% <0.00%> (ø)
suite2p/gui/merge.py 0.00% <0.00%> (ø)
suite2p/gui/rungui.py 0.00% <0.00%> (ø)
suite2p/gui/utils.py 0.00% <0.00%> (ø)
suite2p/detection/detect.py 78.33% <87.50%> (-0.49%) ⬇️

@carsen-stringer carsen-stringer merged commit 3dfca21 into main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants