Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrepareWorld step takes too long on headless #5024

Open
keturn opened this issue May 28, 2022 · 1 comment
Open

PrepareWorld step takes too long on headless #5024

keturn opened this issue May 28, 2022 · 1 comment
Labels
Category: Performance Requests, Issues and Changes targeting performance Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Topic: Concurrency Requests, issues, and changes relating to threading, concurrency, parallel execution, etc. Topic: WorldGen Requests, Issues and Changes related to facets, rasterizers, etc. Type: Bug Issues reporting and PRs fixing problems

Comments

@keturn
Copy link
Member

keturn commented May 28, 2022

loadProcesses.PrepareWorld currently documents itself as "loops until world is pre-generated or 5 second elapsed," and it's good to its word:

public boolean step() {
if (worldRenderer.pregenerateChunks()) {
return true;
}
EngineTime time = (EngineTime) context.get(Time.class);
timeElapsed = time.getRealTimeInMs() - startTime;
return timeElapsed > 5000;

The problem is that the HeadlessWorldRenderer looks like this:

public boolean pregenerateChunks() {
// TODO Auto-generated method stub
return false;

so that loading step always takes five seconds in headless, no matter how much or how little time it takes to generate chunks.

This goes a long way to explaining why even the simplest possible MTE test always takes at least five seconds.

@keturn keturn added Type: Bug Issues reporting and PRs fixing problems Category: Performance Requests, Issues and Changes targeting performance Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Topic: WorldGen Requests, Issues and Changes related to facets, rasterizers, etc. Topic: Concurrency Requests, issues, and changes relating to threading, concurrency, parallel execution, etc. labels May 28, 2022
@keturn
Copy link
Member Author

keturn commented May 28, 2022

I wouldn't try to tackle this before finishing #4798.

I already tried the simple thing of changing the return false to a return true, and while the first MTE test in the run was fine, the next one had problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Performance Requests, Issues and Changes targeting performance Category: Test/QA Requests, Issues and Changes targeting tests and quality assurance Topic: Concurrency Requests, issues, and changes relating to threading, concurrency, parallel execution, etc. Topic: WorldGen Requests, Issues and Changes related to facets, rasterizers, etc. Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Development

No branches or pull requests

1 participant