Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing translations of certain Highlight snippets doesn’t work #12139

Closed
TheoChevalier opened this issue Apr 4, 2024 · 3 comments
Closed

Comments

@TheoChevalier
Copy link
Contributor

TheoChevalier commented Apr 4, 2024

When syncing this highlight snippet I get the following screen
https://foundation.mozilla.org/cms/localize/update/1114/?next=%2Fcms%2Fsnippets%2Fhighlights%2Fhighlight%2Fresults%2F

┆Issue is synchronized with this Jira Bug

@robdivincenzo
Copy link
Collaborator

Hey @TheoChevalier - traced through this a bit as part of grooming.

The form provides a next_url variable in the submit action to return to the snippet listing i.e. cms/snippets/highlights/highlight/ but it seems to tack on a /results/ path to the end (resulting in the broken admin page). I noticed this next_url variable comes from the next query parameter in the URL.

So in the case provided, we can see how /results/ is added to the end. However, you submit the form from a URL without that in the query parameter, you would go to the correct page: https://foundation.mofostaging.net/cms/localize/update/1114/?next=%2Fcms%2Fsnippets%2Fhighlights%2Fhighlight

As a follow-up, where did you get the original URL with the /results/ query parameter? That would help me continue the trace and check for how we might fix this.

@TheoChevalier
Copy link
Contributor Author

Hi @robdivincenzo , thanks for looking into this!

Here are the steps to reproduce:

  1. In the CMS admin, click on "Archived" in the nav menu
  2. Click on Highlights
  3. In the search box at the top, type "WhatsApp". You should see only one result
  4. Click on the 3-dot button then select "Sync translated snippets"
  5. Hit the Submit button

Given the info you provided above, it looks like the search field is altering the query

@data-sync-user
Copy link
Collaborator

➤ Rob DiVincenzo commented:

This appears to be a known wagtail core issue. Related issues and releases linked here: wagtail/wagtail#11177 ( https://github.com/wagtail/wagtail/issues/11177|smart-link )

@mofodevops mofodevops closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants