Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MozFest Homepage - add spacing above signup form #4304

Closed
1 task
mmmavis opened this issue Mar 5, 2020 · 1 comment · Fixed by #4356
Closed
1 task

MozFest Homepage - add spacing above signup form #4304

mmmavis opened this issue Mar 5, 2020 · 1 comment · Fixed by #4356
Assignees
@mmmavis
Labels
engineering frontend
Milestone
Mar 23

Comments

@mmmavis
Copy link
Collaborator

mmmavis commented Mar 5, 2020

Follow-up from #4286 (review)

  • Can we add some spacing between the sign up snippet and the nav? I think 24px should do it:
    Screen Shot 2020-03-05 at 3 51 03 PM

/cc @kristinashu to triage.
@kristinashu kristinashu added this to the Mar 23 milestone Mar 5, 2020
@mmmavis mmmavis self-assigned this Mar 9, 2020
@mmmavis mmmavis mentioned this issue Mar 9, 2020
Merged
@mmmavis
Copy link
Collaborator Author

mmmavis commented Mar 9, 2020

This is not a simple CSS rule change so I'm setting the estimate to 2. This requires JS work to detect when the signup component becomes sticky on the page so we can dynamically adjust the spacing around it.

@mmmavis mmmavis mentioned this issue Mar 17, 2020
Merged
@data-sync-user data-sync-user mentioned this issue Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmmavis mmmavis

Labels
engineering frontend
Projects
None yet
Milestone
Mar 23
2 participants
@kristinashu @mmmavis