Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MozFest Homepage - video controls should appear before video has started playing #4309

Closed
mmmavis opened this issue Mar 6, 2020 · 0 comments · Fixed by #4315
Closed

MozFest Homepage - video controls should appear before video has started playing #4309

mmmavis opened this issue Mar 6, 2020 · 0 comments · Fixed by #4315
Assignees
@mmmavis
Labels
engineering frontend
Milestone
Mar 9

Comments

@mmmavis
Copy link
Collaborator

mmmavis commented Mar 6, 2020 •
edited
Loading

Follow-up for https://github.com/mozilla/foundation.mozilla.org/pull/4296/files#r388647028

Suggested by @Pomax

we may want to take off autoplay and instead trigger a video.play() (and label reveal) only after we know that the play/pause icons have fully loaded, otherwise the video can start playing before the controls are ready.
@mmmavis mmmavis added this to the Mar 9 milestone Mar 6, 2020
@mmmavis mmmavis mentioned this issue Mar 6, 2020
Merged
@mmmavis mmmavis changed the title MozFest Homepage - video controls should appear before video starts MozFest Homepage - video controls should appear before video has started playing Mar 6, 2020
@mmmavis mmmavis self-assigned this Mar 6, 2020
@mmmavis mmmavis mentioned this issue Mar 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmmavis mmmavis

Labels
engineering frontend
Projects
None yet
Milestone
Mar 9
Development

Successfully merging a pull request may close this issue.

MozFest homepage video contrls fixes & align banner text MozillaFoundation/foundation.mozilla.org
1 participant
@mmmavis