Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sitemap #4376

Closed
mmmavis opened this issue Mar 19, 2020 · 4 comments · Fixed by #4495
Closed

Enable sitemap #4376

mmmavis opened this issue Mar 19, 2020 · 4 comments · Fixed by #4495
Assignees
Milestone

Comments

@mmmavis
Copy link
Collaborator

mmmavis commented Mar 19, 2020

Currently, sitemap.xml is exposed (on /sitemap.xml) if the site is on DEBUG mode.

@xmatthewx other than making sure private/draft pages don't get exposed, what are other requirements we need to fulfill? (e.g., is this for internal or external use? do we want to enable sitemap by default on production or just on staging? ... etc)

/cc @Pomax

@xmatthewx
Copy link
Contributor

The main thing is that it would help search engines discover program content that isn't featured on a top level page. And it might help with long tail search traffic to useful resources long after they're featured.

Hopefully our evolved IA solves for much of this, but if it's easy to turn on, let's go for it.

I can't think of any other requirements beyond private/draft.

@cadecairos cadecairos added this to the Apr 6 milestone Mar 24, 2020
@gideonthomas
Copy link
Contributor

@xmatthewx if the IA work is going to introduce a bunch of changes to page discovery, should this wait until the IA is updated so that Google doesn't have to re-index stuff (which can take a while)?

@xmatthewx
Copy link
Contributor

That's a good question. I could see the case for waiting. My gut says proceed, since we don't know how long it'll take to roll out the IA changes, and google should check periodically. And, google has already indexed most of the top level pages as they are. That said, this isn't urgent, so I also think it's fine to push this forward a few sprints. Sorry for the non answer. I say go for it unless Mavis or someone has a reason to want to put it off.

@cadecairos
Copy link

Let's verify that password protected/private pages and drafts don't show up in the site map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants