New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PNI] Product page - add horizontal rules between "end of page" sections #7389

Closed

1 task done

Pomax opened this issue Sep 13, 2021 · 1 comment

Closed

1 task done

[PNI] Product page - add horizontal rules between "end of page" sections #7389

Pomax opened this issue Sep 13, 2021 · 1 comment

Assignees

Labels

buyer's guide 🛍 engineering frontend

Milestone

Contributor

Pomax commented Sep 13, 2021 •

edited by danielfmiranda

Loading

add horizontal rules between the "end of page" sections
- note new styling on these hr

Relevant part of the updated product page comp:

Comps on figma: https://www.figma.com/proto/GwdoUiY4fzVyeLfXsAJGPq/*Privacy-Not-Included-Website?page-id=548%3A72128&node-id=611%3A77813&viewport=283%2C48%2C0.08&scaling=min-zoom&starting-point-node-id=611%3A77813

Pomax added this to the PNI Q3 2021 milestone

Pomax added engineering buyer's guide 🛍 frontend labels

benhohner assigned danielfmiranda and fessehaye

danielfmiranda unassigned fessehaye

danielfmiranda mentioned this issue

7389 section hrs #7452

Merged

Collaborator

danielfmiranda commented Sep 30, 2021

Closing as this has been merged in

danielfmiranda closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment