Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2 [PNI] Search - show search bar on all pages #7474

Closed
2 tasks done
Pomax opened this issue Sep 23, 2021 · 5 comments
Closed
2 tasks done

#2 [PNI] Search - show search bar on all pages #7474

Pomax opened this issue Sep 23, 2021 · 5 comments
Assignees
Labels
buyer's guide 🛍 Issues related to the buyer's guide engineering frontend
Milestone

Comments

@Pomax
Copy link
Contributor

Pomax commented Sep 23, 2021

show search bar on all pages

  • homepage
  • category pages
@Pomax Pomax added this to the PNI Q3 2021 milestone Sep 23, 2021
@Pomax Pomax added the buyer's guide 🛍 Issues related to the buyer's guide label Sep 23, 2021
@jamilasnell jamilasnell changed the title [PNI] Search - show search bar on all pages #2 [PNI] Search - show search bar on all pages Sep 27, 2021
@danielfmiranda
Copy link
Collaborator

Hi @kristinashu, wanted to double check if I was supposed to add the search bar to the product page and if so, where I should put it.

I tried taking a look at the figma comps but was unable to find the search bar anywhere on the page. Thank you!

@kristinashu
Copy link

Hi @danielfmiranda, thank you for checking! There is no search bar on the Product pages (only Home and Category pages).

@kristinashu
Copy link

So maybe this ticket isn't needed?

@danielfmiranda
Copy link
Collaborator

Hi @kristinashu! No Problem, I will still relocate the search bar to the home page and category page, but will remove the product page from the requirements. Thanks!

@danielfmiranda
Copy link
Collaborator

Closing as #7591 is merged in. Thanks everyone for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buyer's guide 🛍 Issues related to the buyer's guide engineering frontend
Projects
None yet
Development

No branches or pull requests

3 participants