Wrap 'card' description with appropriate HTML tags #4360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pomax
suggested changes
Mar 17, 2020
| @@ -9,6 +10,7 @@ def card(image, title, description, link_url, link_label, commitment=None): | |||
| 'image': image, | |||
| 'title': title, | |||
| 'description': description, | |||
| 'description_is_rich_text': BeautifulSoup(description, 'html.parser').p is not None, | |||
There was a problem hiding this comment.
I'm not sure this is a safe way to check this: where is description coming from? Because rich text could also be <ul>...</ul> etc. so we don't want to hardcode that only things with <p> are rich text.
There was a problem hiding this comment.
Ah agreed that this is not very future proof. I only took CTA's subhead into consideration (passed to template tag as description).
subhead = RichTextField(
features=[
'bold', 'italic', 'link',
],
blank=True,
)Will update PR.
Pomax
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4287
Notes: some vertical spacing around the
descritionalso got fixed in this PR as before we had redundant empty<p>nodes hanging around. e.g.,Go to the following pages and look for section that looks like
Hompage
https://foundation-s-issue-4287-fjnyxw.herokuapp.com/en/
Initiatives
https://foundation-s-issue-4287-fjnyxw.herokuapp.com/en/initiatives/
Participate
https://foundation-s-issue-4287-fjnyxw.herokuapp.com/en/participate/