Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing tox to this project #131

Open
1 of 3 tasks
huynguyent opened this issue Feb 5, 2024 · 0 comments
Open
1 of 3 tasks

Introducing tox to this project #131

huynguyent opened this issue Feb 5, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@huynguyent
Copy link

Is your feature request related to a problem? Please describe.

The goal of this project is to maintain compatibility for a wide range of dependencies, for example different versions of pyspark or deltalake. However with the current set up, the test suites only test what is in the lock file. This makes it hard to detect breaking changes, both from upstream and from this project.

Describe the solution you'd like

Use tox to test against different combination of important dependencies, such as pyspark and deltalake

Poetry seems to have tox support but I haven't tried it myself: https://python-poetry.org/docs/faq/#is-tox-supported

Describe alternatives you've considered

Maybe multiple poetry dependency groups if we won't wanna use tox

Additional context
Add any other context or screenshots about the feature request here.

Willingness to contribute

Would you be willing to contribute an implementation of this feature?

  • Yes. I can contribute this feature independently.
  • Yes. I would be willing to contribute this feature with guidance from the mack community.
  • No. I cannot contribute this feature at this time.
@huynguyent huynguyent added the enhancement New feature or request label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant