Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table header aligns always left #3032

Merged
merged 3 commits into from
Dec 14, 2020
Merged

Table header aligns always left #3032

merged 3 commits into from
Dec 14, 2020

Conversation

mojtaba-khallash
Copy link
Contributor

Fix #3028

@HackbrettXXX
Copy link
Collaborator

You probably need to update the PDF reference files for the two failing tests. See https://github.com/MrRio/jsPDF/blob/master/CONTRIBUTING.md#building-and-testing-jspdf

HackbrettXXX
HackbrettXXX requested changes Dec 11, 2020
View reviewed changes
Copy link
Collaborator

@HackbrettXXX HackbrettXXX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes on the files in dist. They are only updated on release. Apart from that, I think the PR is fine, Thanks :)

@mojtaba-khallash
Copy link
Contributor Author

I hope this one line can be applied now :)

@HackbrettXXX HackbrettXXX merged commit c0f6c54 into parallax:master Dec 14, 2020
@HackbrettXXX
Copy link
Collaborator

Thanks for the PR :)

This was referenced Mar 10, 2021
Closed
Closed
Open
Open
Closed
Open
Open
Open
Open
Closed
Open
Open
Open
Merged
Open
Closed
Closed
Open
Closed
Open
This was referenced Mar 12, 2021
Closed
Open
Open
Closed
Closed
Closed
Open
Open
Closed
Closed
Closed
Open
Closed
Open
Closed
Open
Closed
Closed
Merged
Closed
Open
Open
Open
Open
Closed
Closed
Closed
Open
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HackbrettXXX HackbrettXXX HackbrettXXX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table header aligns always left
2 participants
@mojtaba-khallash @HackbrettXXX