Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not descriptive error in GetOrganizationService() method #61

Closed
shytikov opened this issue Mar 11, 2015 · 0 comments
Closed

Not descriptive error in GetOrganizationService() method #61

shytikov opened this issue Mar 11, 2015 · 0 comments
Labels
Milestone

Comments

@shytikov
Copy link
Contributor

If password was not saved, calling ConnectionDetail.GetOrganizationService() will fire ArgumentNullException.

Error itself is fair, but error message is misleading:

Value cannot be null.
Parameter name: s

I think code should throw more descriptive exception, that could be caught and properly solved by calling code (for example by showing input credentials dialog).

Here is call stack:

McTools.Xrm.Connection.dll!McTools.Xrm.Connection.CryptoManager.Decrypt(string cipherText, string passPhrase, string saltValue, string hashAlgorithm, int passwordIterations, string initVector, int keySize) Line 180 + 0xc bytes C#
McTools.Xrm.Connection.dll!McTools.Xrm.Connection.ConnectionDetail.GetOrganizationCrmConnectionString() Line 245 + 0x59 bytes C#
McTools.Xrm.Connection.dll!McTools.Xrm.Connection.ConnectionDetail.GetOrganizationService() Line 307 + 0x9 bytes C#

@MscrmTools MscrmTools added the bug label Mar 11, 2015
@MscrmTools MscrmTools modified the milestone: April release Mar 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants