Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Efficiency Table out of sync when having a limit on Farms, Towers and Cursors #13

Closed
Mtarnuhal opened this issue Nov 1, 2018 · 4 comments · Fixed by #47
Closed

Efficiency Table out of sync when having a limit on Farms, Towers and Cursors #13

Mtarnuhal opened this issue Nov 1, 2018 · 4 comments · Fixed by #47

Comments

@Mtarnuhal
Copy link
Owner

I've noticed that when I have Wizard Tower Cap on that the efficiency table is slowly losing percentages.
https://i.imgur.com/2cqhrej.png

I think this has to do that the building/upgrade is still on the FrozenCookies.caches list.

@geojak
Copy link

geojak commented Nov 1, 2018 via email

@Mtarnuhal
Copy link
Owner Author

Well, they aren't actually blacklisted. They are removed from the array in the "function recommendationList" after the efficiency score has been added.

@adavidw
Copy link
Collaborator

adavidw commented Oct 21, 2020

The easiest approach is just to probably recalculate the efficiency scores/percentages relative to the rest of the array after those items with limits have been removed. However, I'm noticing that the entire recommendations engine runs really slowly, especially at the beginning of an ascension, so I'm wary of adding any new calculations to it. So, we'll probably have actually do it the right way and account for those earlier in the process. Maybe pick up some performance gains to boot.

@Mtarnuhal
Copy link
Owner Author

I agree that it runs slow at the beginning of an ascension. this is mostly due to that the further you are in the game the faster it can buy the next thing and recalculates the list at that point.
if we can exclude them from being picked up in the list before it gets calculated then that would fix. I don't think it will give us a performance boost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants