Gifting #636
Merged
Gifting #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
commented
Jul 1, 2023
benthecarman
force-pushed
the
gifting
branch
3 times, most recently
from
bd48f7a
to
accd272
Compare
|
needs rebase |
TonyGiorgio
reviewed
Jul 8, 2023
benthecarman
force-pushed
the
gifting
branch
2 times, most recently
from
0d888d7
to
1d87fd0
Compare
TonyGiorgio
requested changes
Aug 2, 2023
TonyGiorgio
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Code looks good. Not sure if you want to get in some basic frontend testing first before merging but up to you and @futurepaul
|
Found one issue that I fixed, otherwise only issue seemed to be general nwc stuff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took a stab at the gifting feature. Turns out is is fairly simple, tricky part is making sure the NWC is single use. Need to test and spend some time on that.