Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gifting #540

Closed
15 tasks done
futurepaul opened this issue Sep 19, 2023 · 5 comments
Closed
15 tasks done

Gifting #540

futurepaul opened this issue Sep 19, 2023 · 5 comments

Comments

@futurepaul
Copy link
Collaborator

futurepaul commented Sep 19, 2023

this is mostly done in #421 but need to rebase that PR and then test / make sure it lines up with what we want to accomplish

Purpose

As a kind, benevolent individual I want to onboard my friends to mutiny via a gift.

Should just be available to mutiny+ users.

Frontend

  • create gift
  • redeem gift
  • rebase
  • show gifting link on send screen
  • if not on mutiny+, explain that you need mutiny+
  • update mutiny+ features list
  • warn them if it's lower than 50k
  • can delete a gift
  • add qr scan link to main navbar

Backend

  • functionality

Testing

  • not enough funds on sender
  • too small amount for receiver (if it's a fresh wallet)
  • trying to redeem twice
  • loading from url
  • loading from scanner
@futurepaul futurepaul mentioned this issue Sep 19, 2023
@benalleng
Copy link
Collaborator

benalleng commented Sep 20, 2023

Do you think It's worth adding the qr-scanner to the AmountEditable Page as opposed to the homepage?

I know its currently on the hompage for faster user-flow.

image

@TonyGiorgio
Copy link
Collaborator

TonyGiorgio commented Sep 20, 2023

There's a lot of things a QR code scanner can do that are not related to creating an invoice, which is how you get to that amounts editable screen. LNURL pay/withdraw/auth being some of them.

Though maybe in addition to it can be there

@benalleng
Copy link
Collaborator

benalleng commented Oct 3, 2023

Tested on firefox mobile web

  • Not enough funds on sender error only happens on the receiver side (should probably check the available lightning balance at the time of gift creation)
  • below 50k sats shows a warning on sender and an error on receiver
  • scanner and url both work as expected

@TonyGiorgio
Copy link
Collaborator

Tested on firefox mobile web

  • Not enough funds on sender error only happens on the receiver side (should probably check the available lightning balance at the time of gift creation)
  • below 50k sats shows a warning on sender and an error on receiver
  • scanner and url both work as expected

issues with the PR should be moved here: #421

@TonyGiorgio
Copy link
Collaborator

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants