Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MvvmCross.Droid.Support.Fragment root namespace #3168

Closed
1 of 7 tasks
Plac3hold3r opened this issue Oct 15, 2018 · 2 comments · Fixed by #3181
Closed
1 of 7 tasks

Change MvvmCross.Droid.Support.Fragment root namespace #3168

Plac3hold3r opened this issue Oct 15, 2018 · 2 comments · Fixed by #3181
Labels
p/android-support Android Support Packages platform up-for-grabs Issues up for grabs by anyone

Comments

@Plac3hold3r
Copy link
Contributor

🏗 Enhancement Proposal

I'm not sure if it is an issue with my MvvmCross developer environment setup, but I have intellisense issues with MvvmCross.Droid.Support.Fragment namespace and Fragment types within presenters and playground samples. Everything compiles fine and there are no runtime issues. But at design time I get the following errors

Error CS0118 'Fragment' is a namespace but is used like a type'

Looking at what is using this namespace it seems it's only the inherited resources.

image

Pitch

I purposed to change the root namespace of MvvmCross.Droid.Support.Fragment.dll from MvvmCross.Droid.Support.Fragment to MvvmCross.Droid.Support.Fragments. Initial testing with the playground sample seems to cause no regression.

Platforms affected (mark all that apply)

  • 📱 iOS
  • 🤖 Android
  • 🏁 WPF
  • 🌎 UWP
  • 🍎 MacOS
  • 📺 tvOS
  • 🐒 Xamarin.Forms
@Cheesebaron
Copy link
Member

I think the naming was done because it then followed how the Android Support libraries were named.

@Plac3hold3r
Copy link
Contributor Author

@Cheesebaron do you also get the intellisense errors in Visual Studio 2017 15.8?

@Cheesebaron Cheesebaron added Code improvement up-for-grabs Issues up for grabs by anyone p/android-support Android Support Packages platform labels Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p/android-support Android Support Packages platform up-for-grabs Issues up for grabs by anyone
Development

Successfully merging a pull request may close this issue.

2 participants