Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Etherchain links #1462

Merged
merged 7 commits into from
Apr 6, 2018
Merged

Add Etherchain links #1462

merged 7 commits into from
Apr 6, 2018

Conversation

dternyak
Copy link
Contributor

@dternyak dternyak commented Apr 6, 2018

This PR introduces links to Etherchain on the following views:

  1. Transaction succeeded success notification
  2. Check TX View
  3. Transaction History in Account View
  4. Footer

I'm not completely happy with my implementation, and I spent some time refactoring the network config structure so that we could specify multiple blockchain explorers instead of hard-coding cases in the components themselves. Unfortunately, the refactor overhead was too large for these simple changes, but if this becomes a maintenance issue, a refactor to adjust the network structure to specify multiple explorer (e.g. blockExplorers?: BlockExplorerConfig[]) should be undertaken.

screen shot 2018-04-06 at 9 22 33 am

screen shot 2018-04-06 at 9 22 29 am

screen shot 2018-04-06 at 9 22 14 am

screen shot 2018-04-06 at 9 22 20 am

@coveralls
Copy link

coveralls commented Apr 6, 2018

Pull Request Test Coverage Report for Build 6283

  • 6 of 8 (75.0%) changed or added relevant lines in 4 files are covered.
  • 15 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 33.492%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/components/ExtendedNotifications/TransactionSucceeded.tsx 1 2 50.0%
common/components/Footer/index.tsx 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
common/components/BalanceSidebar/AccountInfo.tsx 1 1.56%
common/components/ExtendedNotifications/TransactionSucceeded.tsx 3 8.33%
common/components/Footer/index.tsx 3 31.25%
common/utils/helpers.ts 8 28.57%
Totals Coverage Status
Change from base Build 6276: -0.02%
Covered Lines: 2295
Relevant Lines: 5811

💛 - Coveralls

@dternyak dternyak added the status: ready for review Open PR's that are ready for technical review. Replaced with "changes needed" or "ready to merge". label Apr 6, 2018
@dternyak dternyak requested a review from wbobeirne April 6, 2018 14:27
Copy link
Contributor

@skubakdj skubakdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good IMO, and I can verify functionality.

@dternyak dternyak merged commit c65296d into develop Apr 6, 2018
@dternyak dternyak deleted the add-etherchain-links branch April 6, 2018 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready for review Open PR's that are ready for technical review. Replaced with "changes needed" or "ready to merge".
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants