[Parity Signer] Do not ask to scan an address twice for a known account #2220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an ability to skip the initial
scan QR
to copy a sender address from the Parity Signer app if its was already scanned before. Currently it uses theaddress book
as it is on theView & Send -> View Address
screen.Also this PR alters (a confusing) wording: instead of saying
Unlock your Parity Signer
(which is just wrong since we do not "unlock" anything on that stage), I've changed it toSelect an account from your Parity Signer
. In other words: user don't have toUnlock your Parity Signer
to retrieve the account address.Here is a more reasoning behind that change: it turns out that people are misled due to misunderstanding on how the process is different from a hardware wallet case: in a Singer case, the actual
account unlocking
happens right (and only) at the moment of signing on the device, never before and never after. So, in reality, the process has more in common with aView Address
than with a hardware wallet case, except that user is able to create TX and show it to the Signer to sign.Suggestions on further improving of the wording are welcome!
Changes
Unlock your Parity Signer
->Select an account from your Parity Signer
Steps to Test
View & Send
Parity Signer
Change Wallet
View & Send
Parity Signer
Use a recent account
sender account
Screenshots
Further improvements
account suggestions list
, which is specific to the Signer. E. g. show addressed which was populated only by QR scan on theParity Signer
screen.account suggestions list
as well as toQR scanner
.Related issues:
#1349
#1945
novasamatech/parity-signer#103