Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Parity Signer] Do not ask to scan an address twice for a known account #2220

Merged
merged 5 commits into from
Dec 5, 2018

Conversation

lexfrl
Copy link
Contributor

@lexfrl lexfrl commented Oct 18, 2018

Description

This PR adds an ability to skip the initial scan QR to copy a sender address from the Parity Signer app if its was already scanned before. Currently it uses the address book as it is on the View & Send -> View Address screen.

Also this PR alters (a confusing) wording: instead of saying Unlock your Parity Signer (which is just wrong since we do not "unlock" anything on that stage), I've changed it to Select an account from your Parity Signer. In other words: user don't have to Unlock your Parity Signer to retrieve the account address.
Here is a more reasoning behind that change: it turns out that people are misled due to misunderstanding on how the process is different from a hardware wallet case: in a Singer case, the actual account unlocking happens right (and only) at the moment of signing on the device, never before and never after. So, in reality, the process has more in common with a View Address than with a hardware wallet case, except that user is able to create TX and show it to the Signer to sign.
Suggestions on further improving of the wording are welcome!

Changes

  • a title Unlock your Parity Signer -> Select an account from your Parity Signer
  • a selector of recent accounts added to make it unnecessary to scan a known account address once again

Steps to Test

  1. Go to View & Send
  2. Select Parity Signer
  3. Scan a QR of account, stored in your Parity Signer
  4. Click on Change Wallet
  5. Go to View & Send
  6. Select Parity Signer
  7. Tap on Use a recent account
  8. There should be an account you're scanned recently - so, you'll be able to proceed with that
    sender account

Screenshots

screen shot 2018-10-19 at 2 25 18 pm

screen shot 2018-10-18 at 3 57 17 pm

Further improvements

  • Use a distinct account suggestions list, which is specific to the Signer. E. g. show addressed which was populated only by QR scan on the Parity Signer screen.
  • Use ERC-681 for an automatic network switch for the specific account. It applies to the account suggestions list as well as to QR scanner.

Related issues:

#1349
#1945
novasamatech/parity-signer#103

@coveralls
Copy link

coveralls commented Oct 18, 2018

Coverage Status

Coverage remained the same at 54.532% when pulling aefaded on fckt:develop into c213287 on MyCryptoHQ:develop.

@lexfrl lexfrl changed the title [Parity Signer] Do not ask to scan an address for a known account twice [Parity Signer] Do not ask to scan twice an address for a known account Oct 18, 2018
@lexfrl lexfrl changed the title [Parity Signer] Do not ask to scan twice an address for a known account [Parity Signer] Do not ask to scan an address twice for a known account Oct 25, 2018
@lexfrl
Copy link
Contributor Author

lexfrl commented Nov 22, 2018

BTW, why AWS CodeBuild us-east-2 (mycryptobuilds-develop) is failing (introduced by this)? Build restart is needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants