Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more descriptive on configuration update outcome #52

Open
krisgesling opened this issue Sep 17, 2020 · 1 comment
Open

Be more descriptive on configuration update outcome #52

krisgesling opened this issue Sep 17, 2020 · 1 comment

Comments

@krisgesling
Copy link
Contributor

It was reported in Chat that Mycroft had responded that it didn't have any configuration updates, yet Skill settings had indeed changed.

The current config update intent is setup in this way. The settings update is triggered, then a configuration update. However the response is only referring to whether the config got updated, it has no idea whether any Skill settings were actually updated or not.

Maybe we need to be more descriptive in the response, particularly because the end user may not see a difference between a configuration (device) and settings (Skills). We do also refer to configurations as "device settings" in various places. Perhaps something like:

I'm syncing your Skill settings.
Your device settings have also been updated.

OR

I'm syncing your Skill settings.
I couldn't find any changes for your device settings.

@krisgesling
Copy link
Contributor Author

Also just saw that this intent doesn't have any Voight Kampff tests. In fixing the above, we should also add one or more tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant