merge CleanupGuard into MythContext

MythTV · Dec 2, 2024 · a57d74a · a57d74a
1 parent a212a84
commit a57d74a
Show file tree

Hide file tree

Showing 8 changed files with 17 additions and 39 deletions.
diff --git a/mythtv/libs/libmyth/mythcontext.cpp b/mythtv/libs/libmyth/mythcontext.cpp
@@ -1664,6 +1664,11 @@ bool MythContext::Init(const bool gui,
 
 MythContext::~MythContext()
 {
+    if (m_cleanup != nullptr)
+    {
+        m_cleanup();
+    }
+
     if (m_impl->m_gui)
     {
         DestroyMythMainWindow();

diff --git a/mythtv/libs/libmyth/mythcontext.h b/mythtv/libs/libmyth/mythcontext.h
@@ -27,6 +27,9 @@ class MPUBLIC MythContext
               bool disableAutoDiscovery = false,
               bool ignoreDB = false);
 
+    using CleanupFunction = void (*)();
+    void setCleanup(CleanupFunction cleanup) { m_cleanup = cleanup; }
+
     bool saveSettingsCache();
 
     void SetDisableEventPopup(bool check);
@@ -37,6 +40,11 @@ class MPUBLIC MythContext
     class Impl;
     Impl   *m_impl {nullptr}; ///< PIMPL idiom
     QString             m_appBinaryVersion;
+    /**
+    This is used to destroy global state before main() returns.  It is called
+    first before anything else is done in ~MythContext() if it is not nullptr.
+    */
+    CleanupFunction     m_cleanup {nullptr};
 };
 
 #endif

diff --git a/mythtv/libs/libmythbase/CMakeLists.txt b/mythtv/libs/libmythbase/CMakeLists.txt
@@ -84,7 +84,6 @@ set(LIBMYTHBASE_HEADERS
 
 set(LIBMYTHBASE_HEADERS_NOT_INSTALLED
     mythbinaryplist.h
-    cleanupguard.h
     configuration.h
     housekeeper.h
     logging.h
@@ -146,7 +145,6 @@ add_library(
   ${LIBMYTHBASE_HEADERS}
   ${LIBMYTHBASE_HEADERS_NOT_INSTALLED}
   ${LIBMYTHBASE_HTTP_HEADERS}
-  cleanupguard.cpp
   configuration.cpp
   dbcheckcommon.cpp
   dbutil.cpp

diff --git a/mythtv/libs/libmythbase/cleanupguard.cpp b/mythtv/libs/libmythbase/cleanupguard.cpp
diff --git a/mythtv/libs/libmythbase/cleanupguard.h b/mythtv/libs/libmythbase/cleanupguard.h
diff --git a/mythtv/libs/libmythbase/libmythbase.pro b/mythtv/libs/libmythbase/libmythbase.pro
@@ -37,7 +37,7 @@ HEADERS += mythsystemlegacy.h mythtypes.h
 HEADERS += threadedfilewriter.h mythsingledownload.h
 HEADERS += ternarycompare.h
 HEADERS += mythsession.h
-HEADERS += cleanupguard.h portchecker.h
+HEADERS += portchecker.h
 HEADERS += mythsorthelper.h mythdbcheck.h
 HEADERS += mythpower.h
 HEADERS += configuration.h
@@ -76,7 +76,7 @@ SOURCES += mythrandom.cpp
 SOURCES += stringutil.cpp
 SOURCES += threadedfilewriter.cpp mythsingledownload.cpp
 SOURCES += mythsession.cpp
-SOURCES += cleanupguard.cpp portchecker.cpp
+SOURCES += portchecker.cpp
 SOURCES += mythsorthelper.cpp dbcheckcommon.cpp
 SOURCES += mythpower.cpp
 SOURCES += configuration.cpp

diff --git a/mythtv/programs/mythbackend/mythbackend.cpp b/mythtv/programs/mythbackend/mythbackend.cpp
@@ -25,7 +25,6 @@
 
 // MythTV
 #include "libmyth/mythcontext.h"
-#include "libmythbase/cleanupguard.h"
 #include "libmythbase/compat.h"
 #include "libmythbase/configuration.h"
 #include "libmythbase/exitcodes.h"
@@ -156,7 +155,7 @@ int main(int argc, char **argv)
         LOG(VB_GENERAL, LOG_CRIT, "Failed to init MythContext.");
         return GENERIC_EXIT_NO_MYTHCONTEXT;
     }
-    CleanupGuard callCleanup(cleanup);
+    context.setCleanup(cleanup);
 
     MythTranslation::load("mythfrontend");
 

diff --git a/mythtv/programs/mythfrontend/mythfrontend.cpp b/mythtv/programs/mythfrontend/mythfrontend.cpp
@@ -36,7 +36,6 @@
 #include "libmyth/mythcontext.h"
 #include "libmyth/mythmediamonitor.h"
 #include "libmyth/standardsettings.h"
-#include "libmythbase/cleanupguard.h"
 #include "libmythbase/compat.h"  // For SIG* on MinGW
 #include "libmythbase/exitcodes.h"
 #include "libmythbase/hardwareprofile.h"
@@ -2024,7 +2023,7 @@ Q_DECL_EXPORT int main(int argc, char **argv)
         gCoreContext->SetExiting(true);
         return GENERIC_EXIT_NO_MYTHCONTEXT;
     }
-    CleanupGuard callCleanup(cleanup);
+    context.setCleanup(cleanup);
 
     SignalHandler::SetHandler(SIGUSR1, handleSIGUSR1);
     SignalHandler::SetHandler(SIGUSR2, handleSIGUSR2);