Support system distro version of exiv2 0.28 with includes C++17 support #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configure file uses the label using_system_libexiv2, while a number of the test.pro files use some variation on this name. This never mattered before because everything had to use the local exiv2. Now that some builds are using the local exiv2 and others are using the system exiv2, this needs to be corrected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to MythTV!
Please review the checklist below to ensure that your contribution
to MythTV is ready for review by our developers.
It is helpful to regularly rebase your pull request to ensure changes
apply cleanly to the current MythTV development branch.
Checklist
While initially C++17 support was not expected to be available until version 1.0, for various organizational reasons 0.28 includes the needed support.
There are currently few distros with 0.28.
NOTE: Compile tested only