Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python tmdb3tv: Allow specials with season number 0 #907

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

rcrdnalor
Copy link
Contributor

tmdb3 lookup.py does not allow queries for tv-season number 0
as raised by @davidjo in #902.

Provided patch in #902 works for me, tested with:

tmdb3tv.py -l en -a GB -D 62974 0 5
tmdb3tv.py -l de -a AT -D 53193 0 3

otherwise, one gets:

~/MythTV/issue_902$ ./share/mythtv/metadata/Television/tmdb3tv.py -l en -a GB -D 62974 0 5
Traceback (most recent call last):
  File "~/MythTV/issue_902/./share/mythtv/metadata/Television/tmdb3tv.py", line 159, in <module>
    sys.exit(main("television",'tmdb3tv.py'))
  File "~/MythTV/issue_902/./share/mythtv/metadata/Television/tmdb3tv.py", line 136, in main
    xml = buildEpisode(args[0:3], opts)
  File "~/MythTV/issue_902/MythTV/tmdb3/lookup.py", line 397, in buildEpisode
    if season.poster:
UnboundLocalError: local variable 'season' referenced before assignment

Checklist

Special episodes are marked with season number 0 in
themoviedb.org/tv and thetvdb.com queries.

Fixes MythTV#902
@rcrdnalor rcrdnalor requested a review from bennettpeter June 1, 2024 18:31
@rcrdnalor rcrdnalor merged commit 6b703aa into MythTV:master Aug 18, 2024
7 of 12 checks passed
@rcrdnalor rcrdnalor deleted the issue_902 branch August 18, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant