Clean up EIT fixes for ProSiebenSat.1 and Vodafone Germany #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like our regression tests are not completely happy: FAIL! : TestEITFixups::testDEPro7Sat1() Compared values are not the same This test can be executed with "make test". |
* Update EIT fixes for ProSiebenSat.1 (Europe): EIT of ProSiebenSat.1 has changed years ago, old fixes do not work any more. ProSiebenSat.1 still dumps all kind of metadata into the subtitle field from where it can be retrieved. * Remove most fixes for Kabel Deutschland: EPG of Vodafone's (formerly Kabel Deutschland) DVB-C is much better today, most fixes are superflous now. Due to frequency/channel changes, the old fixes did not work any more anyway. Only use updated fixes for ProSiebenSat.1 * Remove fixups for German DVB-T: Service got disabled in 2019.
|
I did not even recognize that there are tests.... Fixed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update EIT fixes for ProSiebenSat.1 (Europe): EIT of ProSiebenSat.1 has changed years ago, old fixes do not work any more. ProSiebenSat.1 still dumps all kind of metadata into the subtitle field from where it can be retrieved.
Remove most fixes for Kabel Deutschland: EPG of Vodafone's (formerly Kabel Deutschland) DVB-C is much better today, most fixes are superflous now. Due to frequency/channel changes, the old fixes did not work any more anyway. Only use updated fixes for ProSiebenSat.1
Remove fixups for German DVB-T: Service got disabled in 2019.
Checklist