Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new target-manifest flag for user to provide a manifest (file) of file/directory paths to validate #50

Closed
Tracked by #709
jordanpadams opened this issue Jul 15, 2019 · 4 comments · Fixed by #103
Closed
Tracked by #709

Add new target-manifest flag for user to provide a manifest (file) of file/directory paths to validate #50

jordanpadams opened this issue Jul 15, 2019 · 4 comments · Fixed by #103
Assignees
@jordanpadams @danyu-pds
Labels
enhancement New feature or request requirement New requirements
Milestone
PDS.25 (ends 2019...

Comments

@jordanpadams
Copy link
Member

jordanpadams commented Jul 15, 2019 •
edited
Loading

Current --target flag supports the ability to specify a set of files/directories to validate.

Create a new flag that allows for a target-manifest to be specified that contains a list of files/directories to validate.
@jordanpadams jordanpadams self-assigned this Jul 15, 2019
@galenatjpl galenatjpl changed the title Add capability to specify target with a manifest of products to validate Add capability for User to provide a manifest (file) of products to validate Jul 29, 2019
@jordanpadams jordanpadams added enhancement New feature or request requirement New requirements and removed new-feature-request labels Aug 21, 2019
@danyu-pds
Copy link
Contributor

@jordanpadams @galenatjpl
Dose the milestone change to PDS.26 (was changed 14days ago) from PDS.25 (was added 22days ago)?

What is the different between "a set of files/directories to validate." and "a list of files/directories to validate"?

Do you have a example file of manifest (file)?

@jordanpadams
Copy link
Member Author

jordanpadams commented Sep 13, 2019 •
edited
Loading

@danyu-pds I don't have one off-hand, but you can think of it as a file containing a list of files/directories separated by newlines, e.g.

/path/to/file/a.xml
/path/to/file/b.xml
/path/to/file/c.xml
/path/to/file/d.xml
/path/to/file/e.xml

@danyu-pds
Copy link
Contributor

@danyu-pds I don't have one off-hand, but you can think of it as a file containing a list of files/directories separated by newlines, e.g.

/path/to/file/a.xml
/path/to/file/b.xml
/path/to/file/c.xml
/path/to/file/d.xml
/path/to/file/e.xml

OK. Will do.

danyu-pds pushed a commit that referenced this issue Sep 17, 2019
issue #50:Add capability for User to provide a manifest (file) of
c32db57 
products to validate

Added new option "--target-list-file" for the command line and
"validate.targetListFile" for the config file.

Modified index.xml.vm for the new option.
@danyu-pds
Copy link
Contributor

danyu-pds commented Sep 17, 2019 •
edited
Loading

Added new option "--target-list-file" for the command line and
"validate.targetListFile" for the config file.

Modified index.xml.vm for the new option.

To test:
bin/validate -c [config file]
bin/validate --target-list-file [target list file] -t [target file]
bin/validate --target-list-file [target list file]

Check the target files in the report (Parameters:Targets).

@danyu-pds danyu-pds mentioned this issue Sep 19, 2019
Closed
@jordanpadams jordanpadams changed the title Add capability for User to provide a manifest (file) of products to validate Add new target-manifest flag for user to provide a manifest (file) of products to validate Sep 19, 2019
@jordanpadams jordanpadams changed the title Add new target-manifest flag for user to provide a manifest (file) of products to validate Add new target-manifest flag for user to provide a manifest (file) of file/directory paths to validate Sep 19, 2019
jordanpadams pushed a commit that referenced this issue Sep 19, 2019
@jordanpadams
issue #50:Add capability for User to provide a manifest (file) of
d9e910c 
products to validate

Added new option "--target-list-file" for the command line and
"validate.targetListFile" for the config file.

Modified index.xml.vm for the new option.
@jordanpadams jordanpadams mentioned this issue Sep 19, 2019
Merged
jordanpadams added a commit that referenced this issue Sep 19, 2019
@jordanpadams
Add new target-manifest flag for user to provide a manifest of file/d…
8b8abcf 
…irectory paths (#103)

* issue #50:Add capability for User to provide a manifest (file) of
products to validate

Added new option "--target-list-file" for the command line and
"validate.targetListFile" for the config file.

Modified index.xml.vm for the new option.

* Update flag to target-manifest

Updates also include integration tests and updated documentation.

* Update config key to validate.targetManifest

* Add test data
@jordanpadams jordanpadams mentioned this issue Sep 29, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanpadams jordanpadams

@danyu-pds danyu-pds

Labels
enhancement New feature or request requirement New requirements
Projects
None yet
Milestone
PDS.25 (ends 2019-09-11)
2 participants
@jordanpadams @danyu-pds