NASA-PDS/devops#10

[nutjob4life]

🗒️ Summary

Merge this and it just might make this repository look a bit more like the pds-template-java-repo .

⚙️ Test Data and/or Report

$ env JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_161.jdk/Contents/Home mvn test
[INFO] Scanning for projects...
…
[INFO] Tests run: 672, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
…

♻️ Related Issues

• Rollout template updates to existing repos devops#10

[jordanpadams]

@nutjob4life looks good. for future java rollouts, can we make updates similar to d46b049 ? I just noticed we were not including the NOTICE and CHANGELOG (where it exists). As we are going through and scrubbing all these anyways, I think they would be useful for users?

[nutjob4life]

Okay, thanks @jordanpadams. I'll try to remember to update the assembly files with the administrivia.

Also, the Roundup uses openjdk8 by default:

$ docker container run --rm --entrypoint /usr/bin/java nasapds/pds-github-actions-base -version
openjdk version "1.8.0_275"
OpenJDK Runtime Environment (IcedTea 3.17.1) (Alpine 8.275.01-r0)
OpenJDK 64-Bit Server VM (build 25.275-b01, mixed mode)

so explicitly mentioning it won't do anything unless we revert to an older version of Java in the GitHub Actions base image. (A newer version also has no effect, because to use an older version than Roundup also requires both installing the package and setting an environment variable.)