Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish consistency between how Provenance and the API select (filter) documents by archive_status #308

Closed
jimmie opened this issue Apr 5, 2023 · 2 comments

Comments

@jimmie
Copy link
Member

jimmie commented Apr 5, 2023

This isn't technically a bug, but more an issue of being vulnerable to inconsistency.

With regards to archive_status, the API selects documents which have one of a (configurable) set of values (typically archived, certified). Provenance on the other hand selects documents which do not have an archive_status of staged - the item of note being that in the provenance case, documents without a value for archive_status qualify. The end result is there can be a series of vids that sequentially point to a document that does have an archive_status.

When the API is looking for a product record, the query includes criteria of no value for superseded_by and archive_status of archived or certified. However, because provenance works by exclusion, we could end up with no qualifying vids for a lid (i.e. all have a superseded_by except for one that has no archive_status).

To best avoid this occurrence, provenance should request documents in the same inclusive manner as the API.

@jimmie
Copy link
Member Author

jimmie commented Apr 5, 2023

Assigning to myself for now to establish visibility during stand-up.

@alexdunnjpl
Copy link
Contributor

Short-term, resolved by #312
Long-term, will be addressed by #309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants