-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a PDS operator, I want to know the health of the registry API service #336
Comments
Derived from registry-api #297 |
@jimmie can we also be sure to include a check that there is non-zero results returned? basically just making sure there is actually data in the registry too, not just that everything is running. |
Sure, we can do that - maybe get a count of documents and include that in the return payload? Note that this will not constitute a failure on the part of the healthcheck (i.e. there may be zero documents but if everything else checks out OK a 200 will still be returned) since the intention for this is to convey to ECS/Fargate of whether the task needs to be recycled. |
@jimmie what are you thinking of, regarding the springboot metrics ? |
@tloubrieu-jpl I am not 100% sure, I did a quick (very quick) scan and saw hints that there may be some useful information but it may prove to be very difficult to access. I was hoping for something like # of requests, response rates, etc to include in the response payload but maybe I'm being too optimistic. |
Thanks @jimmie I was seeing the springboot can provide a specific URL for those metrics, maybe we could expose it separatelly, maybe with a logn/passowrd protection. It is not critical and not part of this ticket anyway. |
@jimmie can you help with the off-nominal response code(s) expected for the 2 failure acceptance criteria described in the original ticket above? Or if there are other acceptance criteria you think are worth noting (e.g. 404 vs 418 vs 501 vs ...) |
Waiting for @jimmie to create a PR (I pinged him on slack today) |
endpoint done. tests needed added to icebox |
This indication will be based on a new API endpoint specific to indicating the health of the service. The primary purpose of this is to provide a comprehensive assessment of if the service is healthy, to be used as the healthcheck for the service listener.
Sending a request to this endpoint will provide a summary of the following:
Failures or certain levels of the above info will result in a non-200 return code.
The determined state of health will be:
Once available, we will need to update the terraform scripts to include this endpoint in the listener healthcheck definition.
Acceptance Criteria
Given a nominal running Registry API and OpenSearch registry
When I perform a query of the
healthcheck/
endpointThen I expect to receive a 200 response and metadata indicating a successful running application
Given a running Registry API and OpenSearch registry, with an off-nominal state for the Registry API
When I perform a query of the
healthcheck/
endpointThen I expect to receive TBD response code(s) and applicable metadata
Given a running Registry API and Registry (OpenSearch), with an off-nominal state for the Registry (OpenSearch)
When I perform a query of the
healthcheck/
endpointThen I expect to receive TBD response code(s) and applicable metadata
Sub-tasks
The text was updated successfully, but these errors were encountered: