Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As an API user, I want to know the Bundle for a given Product. #454

Closed
2 tasks
jordanpadams opened this issue Mar 26, 2021 · 2 comments
Closed
2 tasks

As an API user, I want to know the Bundle for a given Product. #454

jordanpadams opened this issue Mar 26, 2021 · 2 comments
Assignees
Labels
B12.0 B13.0 p.must-have requirement the current issue is a requirement

Comments

@jordanpadams
Copy link
Member

jordanpadams commented Mar 26, 2021

For more information on how to populate this new feature request, see the PDS Wiki on User Story Development:

https://github.com/NASA-PDS/nasa-pds.github.io/wiki/Issue-Tracking#user-story-development

Motivation

...so that I can <why do you want to do this?>

Additional Details

Notional API Design:

GET /products/{identifier}/member-of/member-of

See NASA-PDS/registry#109 and NASA-PDS/registry#108 for how the registry ingests primary and secondary products.

Note: This logic is a little funkier for secondary bundles:

  1. find all collections this product belongs to (as a primary or secondary product)
  2. find all bundles those collections belong to (as a primary or secondary collection)

Acceptance Criteria

Given I have a product LID OR LIDVID
When I perform an API query by that LIDVID for its grandparent bundle(s)
Then I expect the API to returns the primary bundle (there should be only 1) AND any secondary bundle(s) (could be many) the product belongs to

Sub-tasks

  • Update Swagger API
  • Implement in API Server
@jordanpadams jordanpadams added requirement the current issue is a requirement needs:triage labels Mar 26, 2021
@jordanpadams jordanpadams self-assigned this Mar 26, 2021
@jordanpadams jordanpadams changed the title As a user, I want to search for a product's bundle As a user, I want to know for the bundle for a given product. Mar 26, 2021
@jordanpadams jordanpadams changed the title As a user, I want to know for the bundle for a given product. As a user, I want to know the bundle for a given Product. Mar 26, 2021
@jordanpadams jordanpadams changed the title As a user, I want to know the bundle for a given Product. As a user, I want to know the Bundle for a given Product. Mar 26, 2021
@jordanpadams jordanpadams changed the title As a user, I want to know the Bundle for a given Product. As an API user, I want to know the Bundle for a given Product. Mar 26, 2021
@gxtchen
Copy link

gxtchen commented Aug 30, 2022

@jordanpadams @jimmie @ramesh-maddegoda I need test data for /products/{lidvid}/bundles, can you help me download and load it to the docker image? thanks.

@jordanpadams
Copy link
Member Author

jordanpadams commented Aug 30, 2022

@gxtchen I am thinking it is probably best if you use data we are not using for our test cases? Here are some test bundles/collections we have grabbed for testing: https://pds.nasa.gov/data/pds4/test-data/registry/

@rchenatjpl also put together a custom bundle for testing purposes here: https://pds.nasa.gov/data/pds4/test-data/custom-datasets/

Those paths map to pds-int:/data/pds4/test-data/ if you want to use the data from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B12.0 B13.0 p.must-have requirement the current issue is a requirement
Projects
None yet
Development

No branches or pull requests

5 participants