Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate gives errors for 'NaN' and 'Inf' values in IEEE754 data #644

Closed
mnhughes opened this issue May 12, 2023 · 3 comments · Fixed by #646
Closed

Validate gives errors for 'NaN' and 'Inf' values in IEEE754 data #644

mnhughes opened this issue May 12, 2023 · 3 comments · Fixed by #646
Assignees
Labels

Comments

@mnhughes
Copy link

mnhughes commented May 12, 2023

Checked for duplicates

Yes - I've already checked

🐛 Describe the bug

When validating M2020 SuperCam FITS data files, validate v. 3.2.0 gives an error for 'NaN' and 'Inf" values in the data.
SuperCamFITSvalidate.zip

Why does validate say that these values aren't allowed in IEEE754MSBDouble data? I can't find anything saying this in the PDS4 standards. I only see these values aren't allowed in ASCII data.

Validate 3.2.0 is also still giving the offset error for tables defined out of order which I thought was fixed in 3.2.0.

🕵️ Expected behavior

I expected this product to pass validation.

📜 To Reproduce

...

🖥 Environment Info

  • Version of this software [e.g. vX.Y.Z]
  • Operating System: [e.g. MacOSX with Docker Desktop vX.Y]
    ...

📚 Version of Software Used

3.2.0

🩺 Test Data / Additional context

No response

🦄 Related requirements

🦄 #532
🦄 #514

⚙️ Engineering Details

No response

@al-niessner
Copy link
Contributor

@jordanpadams @mnhughes

I am getting this error in the sample data and do not understand it well enough to fix it. It also seems unrelated to this ticket:

  FAIL: file:/home/niessner/Projects/PDS/validate/src/test/resources/github644/scam_0072_0673327336_185_cp2_scam01072_scct_41_irsalign_____04p04.xml
      ERROR  [error.label.invalid_object_definition]   line 12: Invalid object definition for object #12.  The previously defined object ends at byte 146432. Offset defined in label: 141120
        1 product validation(s) completed

May have missed it in the flood of NAN errors but those have been removed. Please help me fix this error in the XML for FITS to close this ticket.

@jordanpadams
Copy link
Member

@al-niessner @mnhughes it looks like the IR HK TABLE starts at byte 138240, and has an object length of 8192 bytes (256 records x 32 byte record length), so the SPECTRA HEADER object should have an offset of 146432. the remaining offsets are probably after that as well

@mnhughes
Copy link
Author

I talked with the data provider and there was an error in their label templates which likely caused that issue (as well as the values in some of the tables that were very off).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

4 participants