Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate catches valid_maximum but not valid_minimum #785

Closed
rchenatjpl opened this issue Dec 8, 2023 · 0 comments Β· Fixed by #794
Closed

validate catches valid_maximum but not valid_minimum #785

rchenatjpl opened this issue Dec 8, 2023 · 0 comments Β· Fixed by #794
Assignees
Labels

Comments

@rchenatjpl
Copy link
Contributor

rchenatjpl commented Dec 8, 2023

Checked for duplicates

Yes - I've already checked

πŸ› Describe the bug

validate catches values above Special_Constants/valid_maximum but not values below Special_Constants/valid_minimum

πŸ•΅οΈ Expected behavior

The attached data file has 2 lines with values too large and 4 lines with values too small. Validate only calls out the large ones

πŸ“œ To Reproduce

% validate -t 00038_FGM_RTN.xml
PDS Validate Tool Report
Configuration:
Version 3.4.0-SNAPSHOT
Date 2023-12-08T22:34:00Z
Parameters:
Targets [file:/Users/rchen/Desktop/00038_FGM_RTN.xml]
Severity Level WARNING
Recurse Directories true
File Filters Used [*.xml, *.XML]
Data Content Validation on
Product Level Validation on
Max Errors 100000
Registered Contexts File /Users/rchen/PDS4tools/validate/resources/registered_context_products.json
Product Level Validation Results
PASS: file:/Users/rchen/Desktop/00038_FGM_RTN.xml
Begin Content Validation: file:/Users/rchen/Desktop/00038_FGM_RTN.TAB
WARNING [warning.table.field_value_out_of_special_constant_min_max_range] data object 1, record 7, field 3: Field has a value '57380.348' that is greater than the defined maximum value '44000.000'.
WARNING [warning.table.field_value_out_of_special_constant_min_max_range] data object 1, record 16, field 2: Field has a value '6666666.6' that is greater than the defined maximum value '44000.000'.
End Content Validation: file:/Users/rchen/Desktop/00038_FGM_RTN.TAB
1 product validation(s) completed
Summary:
0 error(s)
2 warning(s)
Product Validation Summary:
1 product(s) passed
0 product(s) failed
0 product(s) skipped
Referential Integrity Check Summary:
0 check(s) passed
0 check(s) failed
0 check(s) skipped
Message Types:
2 warning.table.field_value_out_of_special_constant_min_max_range
End of Report
Completed execution in 4400 ms

πŸ–₯ Environment Info

  • Version of this software [e.g. vX.Y.Z]
  • Operating System: [e.g. MacOSX with Docker Desktop vX.Y]
    ...

πŸ“š Version of Software Used

% validate -V
gov.nasa.pds:validate
Version 3.4.0-SNAPSHOT
Release Date: 2023-12-06 19:26:36

🩺 Test Data / Additional context

Archive.zip

πŸ¦„ Related requirements

πŸ¦„ #xyz

βš™οΈ Engineering Details

I&T Details

TestRail Test ID: T8681198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🏁 Done
Status: Release Backlog
4 participants