process both min and max special constants #793
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 7, 2023 11:34
Parse the aggregations to query back for the lids that reference it. Then compress those lids in a set then report duplicates if the set is bigger than 1. This allows many lidvids to point at the same thing if they have the same lid. Tested using the m2020 pixl data from harvest#143 after duplicating one element for the check to find. Runs successfully.
|
Did not branch from main making this branch all messed up. Kill it and ignore it! |
|
I've done that myself! 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
The check for min/max special constants was written to return results immediately if either min/max was given. Had to alter processing to do both min and max.
⚙️ Test Data and/or Report
Automated unit tests below all pass
♻️ Related Issues
Closes #785