-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Program to remove obs above a given CAM model level from an obs_seq file #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assimilating obs at the cam model top leads to problems because the model top has a fixed upper bound. this program uses the routine inside the cam model_mod.f90 to remove obs above a given model level.
and fixed typos in the previous commit (camdart -> cam_dart changes).
Added E_WARN to the program.
There is &cam_dart_obs_preprocessor_nml in work/input.nml
mjs2369
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and tested. Works as specified, approved.
hkershaw-brown
commented
Jun 2, 2023
Some sphinx errors to fix:
|
Retested after being merged with main. Ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is Nancy's preprocessor for CAM to remove obs above a certain level.
Fixes issue
Fixes #459
Types of changes
Documentation changes needed?
Note, I think we can pull out some of the documentation, e.g. 'future plans', 'files'.
Tests
Please describe any tests you ran to verify your changes.
Unknown.
Checklist for merging
Checklist for release
Testing Datasets
I think you can test this with any obs_seq.out that you would use with CAM.