Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program to remove obs above a given CAM model level from an obs_seq file #480

Merged
merged 17 commits into from
Jun 27, 2023

Conversation

hkershaw-brown
Copy link
Member

@hkershaw-brown hkershaw-brown commented May 26, 2023

Description:

This is Nancy's preprocessor for CAM to remove obs above a certain level.

Fixes issue

Fixes #459

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Note, I think we can pull out some of the documentation, e.g. 'future plans', 'files'.

Tests

Please describe any tests you ran to verify your changes.
Unknown.

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

I think you can test this with any obs_seq.out that you would use with CAM.

nancycollins and others added 9 commits November 28, 2022 14:21
assimilating obs at the cam model top leads to problems because
the model top has a fixed upper bound.  this program uses the routine
inside the cam model_mod.f90 to remove obs above a given model level.
and fixed typos in the previous commit (camdart -> cam_dart changes).
There is &cam_dart_obs_preprocessor_nml in work/input.nml
@hkershaw-brown hkershaw-brown requested a review from mjs2369 May 26, 2023 13:31
Copy link
Contributor

@mjs2369 mjs2369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested. Works as specified, approved.

@hkershaw-brown hkershaw-brown marked this pull request as draft June 2, 2023 13:01
@hkershaw-brown
Copy link
Member Author

Some sphinx errors to fix:

/home/docs/checkouts/readthedocs.org/user_builds/dart-documentation/checkouts/480/models/cam-fv/cam_dart_obs_preprocessor.rst:2: WARNING: Title underline too short.

program ``cam_dart_obs_preprocessor``
====================
checking consistency... /home/docs/checkouts/readthedocs.org/user_builds/dart-documentation/checkouts/480/models/cam-fv/cam_dart_obs_preprocessor.rst: WARNING: document isn't included in any toctree
generating indices... /home/docs/checkouts/readthedocs.org/user_builds/dart-documentation/checkouts/480/models/cam-fv/cam_dart_obs_preprocessor.rst:60: WARNING: unknown document: '../../modules/utilities/time_manager_mod'

should be a link:
Screen Shot 2023-06-02 at 9 07 10 AM

@mjs2369
Copy link
Contributor

mjs2369 commented Jun 5, 2023

Retested after being merged with main. Ready to merge.

@hkershaw-brown hkershaw-brown added the release! bundle with next release label Jun 6, 2023
@hkershaw-brown hkershaw-brown marked this pull request as ready for review June 22, 2023 19:33
@hkershaw-brown hkershaw-brown merged commit b0ae3db into main Jun 27, 2023
@hkershaw-brown hkershaw-brown deleted the high-cam branch June 27, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release! bundle with next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: program to remove obs above a given CAM model level from an obs_seq file
4 participants