Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unit of errmsg in metavar.py (and/or metadata_parser.py, ccpp-physics, fv3atm, scm) (4 hours) #397

Closed
climbfuji opened this issue Aug 18, 2021 · 0 comments · Fixed by #428, NOAA-EMC/fv3atm#467 or ufs-community/ufs-weather-model#1013
Labels
capgen bugs, requests, etc. that involve ccpp_capgen capgen-unification ccpp_prebuild bugs, requests, etc. that involve ccpp_prebuild enhancement

Comments

@climbfuji
Copy link
Collaborator

climbfuji commented Aug 18, 2021

Description

There is a mismatch between the unit of variable errrmsg in metavar.py and the ccpp-physics/fv3atm/scm repositories (which are using none).

Based on the discussion in the recent CCPP framework developer meetings (08/11/2021 and 08/18/2021), the unit for errmsg should probably be none.

This particular change is part of a broader effort to align units between the dictionary of standard names and the ccpp-physics, fv3atm and scm repositories, see ESCOMP/CCPPStandardNames#19.

Solution

Change unit for errmsg in metavar.py from 1 to none in feature/capgen. Merge this update to main, then remove the workaround in parse_checkers.py that was added in PR #391 for the main branch.

Alternatives (optional)

In case we decide to use a different unit for errmsg, update metavar.py, ccpp prebuild's metadata_parser.py, ccpp-physics, fv3atm, scm. This will be a big change in ccpp-physics, since errmsg is a mandatory variable for every scheme, but it should be straightforward.

Related to (optional)

ESCOMP/CCPPStandardNames#19

@climbfuji climbfuji added enhancement capgen bugs, requests, etc. that involve ccpp_capgen capgen-unification ccpp_prebuild bugs, requests, etc. that involve ccpp_prebuild labels Aug 18, 2021
@climbfuji climbfuji changed the title Update unit of errmsg in metavar.py (and/or metadata_parser.py, ccpp-physics, fv3atm, scm) Update unit of errmsg in metavar.py (and/or metadata_parser.py, ccpp-physics, fv3atm, scm) (4 hours) Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment