Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VarDictionary doctests broken for python3.12 #557

Closed
peverwhee opened this issue Apr 22, 2024 · 0 comments · Fixed by #549
Closed

VarDictionary doctests broken for python3.12 #557

peverwhee opened this issue Apr 22, 2024 · 0 comments · Fixed by #549
Labels

Comments

@peverwhee
Copy link
Collaborator

peverwhee commented Apr 22, 2024

Description

The VarDictionary doctests are failing because of this change in python3.12:

gh-101446: Change repr of collections.OrderedDict to use regular dictionary formating instead of pairs of keys and values

Steps to Reproduce

Run the doctests overall or for only metavar.py

Additional Context

Here is the difference:

Expected:
VarDictionary(baz, [('hi_mom', <metavar.Var hi_mom: foo at 0x...>)])
Got:
VarDictionary(baz, {'hi_mom': <metavar.Var hi_mom: foo at 0x7f6c73e92990>})

Need to decide whether to move away from using the string representations of the base python classes (OrderedDict, etc) so we're unaffected by this. Or if we need to update the doctests themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant