Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement that suite files begin with "suite_" #568

Open
mkavulich opened this issue May 24, 2024 · 0 comments · Fixed by #569
Open

Remove requirement that suite files begin with "suite_" #568

mkavulich opened this issue May 24, 2024 · 0 comments · Fixed by #569
Assignees

Comments

@mkavulich
Copy link
Collaborator

Description

As part of a new set of suite naming guidelines (see NCAR/ccpp-doc#72), we are removing the requirement that suite definition file names begin with the literal string suite_. SDF filenames will still need to match the suite name, but without the suite_ prefix. Currently this requirement is hard-coded into CCPP prebuild (but not in capgen).

Solution

The logic that checks for suite definition files in prebuild needs to be updated to remove the suite_ prefix requirement. This check occurs in a few different places so this will be a bit more than a one-line change, especially due to extra logic to maintain back-compatibility with the old naming style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant