Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostic_name metadata field #635

Open
peverwhee opened this issue Feb 3, 2025 · 2 comments
Open

Add diagnostic_name metadata field #635

peverwhee opened this issue Feb 3, 2025 · 2 comments
Assignees

Comments

@peverwhee
Copy link
Collaborator

Description

Add new diagnostics name metadata field to be used by the constituents object*

*Note: for now, the new metadata field will only be used by the constituents object, but can be extended to be used by the amorphous future diagnostics object (#579)

Related to #461

Solution

  1. Add new optional metadata field - diagnostic_name - to the metadata.
  2. Add new diagnostics name attribute to the constituents object that is set to the diagnostic name field in the metadata (or through the instantiate call)
@gold2718
Copy link
Collaborator

gold2718 commented Feb 4, 2025

How is this diagnostic_name used? For a single constituent, there may be many places where the value of a constituent may want to be sampled. Is this name just for host model use? Is it a base name for other uses (e.g., <diagnostic_name>_after_dynamics, <diagnostic_name>_before_microphysics)?

@peverwhee
Copy link
Collaborator Author

For now at least, it will just be host model use. It'll be up to the host model to add _after_dynamics if necessary (so, I guess just a base name as you say).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants