Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several PBL tendencies are wrong or missing #490

Closed
grantfirl opened this issue Aug 18, 2020 · 1 comment
Closed

Several PBL tendencies are wrong or missing #490

grantfirl opened this issue Aug 18, 2020 · 1 comment

Comments

@grantfirl
Copy link
Collaborator

The following code was observed to be in error:

  • moninedmf.f: diagnostic tendencies divided by timestep twice and T-tendency erroneously subtract radiative heating rates
  • satmedmfvdifq.F: diagnostic T and q tendencies erroneously multiplied by TKE dissipation coefficient
  • module_MYNNPBL_wrapper.F90: diagnostic T-tendency erroneously subtract radiative heating rates
  • ysuvdif.F90 - missing diagnostic tendencies
  • shinhongvdif.F90 - missing diagnostic tendencies
@grantfirl grantfirl mentioned this issue Aug 18, 2020
Merged
@climbfuji
Copy link
Collaborator

Closed via #489.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@climbfuji @grantfirl