Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an action to publish to pypi when we make a release #159

Closed
Tracked by #93
mattldawson opened this issue Jun 21, 2024 · 2 comments · Fixed by #184
Closed
Tracked by #93

Create an action to publish to pypi when we make a release #159

mattldawson opened this issue Jun 21, 2024 · 2 comments · Fixed by #184
Assignees
Labels
enhancement New feature or request

Comments

@mattldawson
Copy link
Collaborator

mattldawson commented Jun 21, 2024

Add an action that publishes the MUSICA Python wrapper to pypi for each release.

Acceptance Criteria

  • The MUSICA Python package is deployed to pypi on each commit to the release branch

Ideas

  • Follow the logic here and here
  • Apparently, can set up publishers with pypi so that we don't need to store a token
  • Investigate whether it's possible to have the version number in just one place, instead of in both the CMakeLists.txt file and pyproject.toml
@mattldawson mattldawson added the enhancement New feature or request label Jun 21, 2024
@mattldawson mattldawson added this to the MUSICA Python wrapper milestone Jun 21, 2024
@K20shores K20shores self-assigned this Jul 30, 2024
@WardF
Copy link
Collaborator

WardF commented Aug 2, 2024

This was part of the discussion we had had @K20shores if I'm not mistaken, should I take this on as well?

@K20shores
Copy link
Collaborator

@WardF yes, but also I ended up workin on this last week and #184, I think, accomplishes this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants