Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water class hard coded in NWM IO. #455

Closed
kafitzgerald opened this issue Feb 17, 2020 · 1 comment
Closed

Water class hard coded in NWM IO. #455

kafitzgerald opened this issue Feb 17, 2020 · 1 comment
Assignees
Labels
bug Something isn't working I/O Input/Output related issues

Comments

@kafitzgerald
Copy link
Contributor

Thanks to a WRF-Hydro user for pointing out the following issue.

I'll put in a PR shortly that should be applied to v5.0.x (if we're still maintaining this version), v5.1.x, and master.

##Expected Behavior
Only water classes should be filled with NaNs in NoahMP outputs.

Current Behavior

Land use category 16 is getting filled with NaNs for a valid land class in the MODIS categories. Effectively, the water category for the USGS classes was hard coded in the output routines.

Possible Solution

Change the following hard coded waterVal = 16 to waterVal = rt_domain(domainId)%iswater

Steps to Reproduce (for bugs)

Run the model with MODIS land use categories and output LDASOUT files with NWM output routines.

@kafitzgerald kafitzgerald self-assigned this Feb 17, 2020
@kafitzgerald kafitzgerald added bug Something isn't working I/O Input/Output related issues labels Feb 17, 2020
@kafitzgerald
Copy link
Contributor Author

Addressed in PR#456 and PR#457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working I/O Input/Output related issues
Projects
None yet
Development

No branches or pull requests

1 participant