You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks to a WRF-Hydro user for pointing out the following issue.
I'll put in a PR shortly that should be applied to v5.0.x (if we're still maintaining this version), v5.1.x, and master.
##Expected Behavior
Only water classes should be filled with NaNs in NoahMP outputs.
Current Behavior
Land use category 16 is getting filled with NaNs for a valid land class in the MODIS categories. Effectively, the water category for the USGS classes was hard coded in the output routines.
Possible Solution
Change the following hard coded waterVal = 16 to waterVal = rt_domain(domainId)%iswater
Thanks to a WRF-Hydro user for pointing out the following issue.
I'll put in a PR shortly that should be applied to v5.0.x (if we're still maintaining this version), v5.1.x, and master.
##Expected Behavior
Only water classes should be filled with NaNs in NoahMP outputs.
Current Behavior
Land use category 16 is getting filled with NaNs for a valid land class in the MODIS categories. Effectively, the water category for the USGS classes was hard coded in the output routines.
Possible Solution
Change the following hard coded
waterVal = 16
towaterVal = rt_domain(domainId)%iswater
wrf_hydro_nwm_public/trunk/NDHMS/Routing/module_NWM_io.F
Line 1124 in 80395eb
Steps to Reproduce (for bugs)
Run the model with MODIS land use categories and output LDASOUT files with NWM output routines.
The text was updated successfully, but these errors were encountered: