Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dealing with access at more granular levels #207

Closed
NCIEVS opened this issue Mar 3, 2017 · 11 comments
Closed

Dealing with access at more granular levels #207

NCIEVS opened this issue Mar 3, 2017 · 11 comments

Comments

@NCIEVS
Copy link
Collaborator

NCIEVS commented Mar 3, 2017

Derived from the utilization of Def_Curator and Special_Review.
Increased granularity in access control

  • mark properties as restricted, editable only by specific users
  • mark concepts as restricted, editable only by specific users
  • mark branches as restricted, editable only by specific users

For now, mark definitions with a DONOTTOUCH source replacing Special_Review

See the wiki

@NCIEVS NCIEVS added this to the Future Release milestone Mar 3, 2017
@bdionne bdionne modified the milestones: v1.1 - nci-1.009, Future Release Aug 3, 2017
@bdionne
Copy link
Collaborator

bdionne commented Aug 3, 2017

see WIKI for details

@singhik
Copy link
Collaborator

singhik commented Apr 4, 2018

@NCIEVS @bdionne ::
Can you please provide Steps to Reproduce on this issue in terms of what level of granular access has been restricted and for which operations ? Is it role specific or user specific ?

@bdionne
Copy link
Collaborator

bdionne commented Apr 5, 2018

The idea here is to use one annotation property to restrict another. The software assumes a property called restricted_by, whose value is the IRI of another property. In this case we add restricted_by to DEFINITION and it's value is definition_curator. Don't confuse this with Def_Curator which mat be there for legacy purposes, but should probably be cleaned out at some point.

definition_curator has a range of definition_curator_enum and definition_curator_enum has a value that is a set of names, in this case cancer_curators and drug_curators. Each of these is an enum whose value will be specific users.

To restrict editing of DEFINITION on a specific class, add the definition_curator property to the class, selecting as value for it the desired enum.

The screenshots below show how this was done for SmallBase

screen shot 2018-04-05 at 11 51 25 am

screen shot 2018-04-05 at 11 51 40 am

screen shot 2018-04-05 at 11 52 00 am

screen shot 2018-04-05 at 11 52 20 am

screen shot 2018-04-05 at 11 53 07 am

@singhik
Copy link
Collaborator

singhik commented Apr 11, 2018

@bdionne @NCIEVS :: Hi , Restriction works for non-allowed users to not Add/Edit 'DEFINITION' Complex property but for the list of allowed users, addition/edition of 'DEFINITION' only works when the User Name is specified as complete name (Itendra Singh) but not when userid is specified (singhik) under 'DataType definitions', can you please confirm if this is expected ? Below screen print shows the details ::

When userid (singhik) is added as part of restriction group, DEFINITION add/edit is not allowed ::

image

When complete Name (Itendra Singh) is added as part of restriction group, then DEFINITION add/edit is allowed ::

image

@bdionne
Copy link
Collaborator

bdionne commented Apr 11, 2018

nice catch, @singhik - this is just a bug - and fixed - I just finished merging another bug fix for #366 - let me check with @NCIEVS tomorrow about pushing another edit tab plugin, maybe we'll throw that in also, or just tease this out separately as a separate commit otherwise

@NCIEVS
Copy link
Collaborator Author

NCIEVS commented Apr 12, 2018

@bdionne, we can talk about it today, but it seems to me this one is safe and can be pushed anytime.

@bdionne
Copy link
Collaborator

bdionne commented Apr 12, 2018

This is now fixed in 0.8.1

@singhik
Copy link
Collaborator

singhik commented Apr 12, 2018

@bdionne : Hi Bob, Thanks, User id (singhik) now works as the list of allowed users to Add/Edit DEFINITION .

For restricted users, ADD and EDIT of DEFINITION is not allowed, however DELETE of DEFINITION is allowed for restricted users, need to confirm if DELETE is part of allowed operation for restricted users ?

@bdionne
Copy link
Collaborator

bdionne commented Apr 13, 2018

Delete should be restricted also, I just pushed a fix for that case.

@singhik singhik added the pass label Apr 13, 2018
@singhik
Copy link
Collaborator

singhik commented Apr 13, 2018

QA has verified Edition,Deletion,Addition of DEFINITION complex property as NOT allowed for 'restricted users'.
QA has verified Edition,Deletion,Addition of DEFINITION complex property as allowed for 'non-restricted users' with userid .

Attached doc with screen prints ....
Issue 207.docx

@bdionne
Copy link
Collaborator

bdionne commented Apr 19, 2018

this is done? closing it, please reopen if not

@bdionne bdionne closed this as completed Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants