-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sniper with automated pokelocation feed #1349
Conversation
Fixed multithreading access issues to the snipeLocations. GPX pathing has a flaw and never calls functions inside while (pokestopList.Any()) because all pokestops have been already looted by UseNearbyPokestopsTask. So i moved the SnipeAtPokestops call out of it. To prevent too many snipe lookups i added the minsnipedelay
And minor bugfixes
Wow, this is epic! |
Before anyone asks, the bot will not be made public until one of the discord admins restricts the permissions to read-only on the #sniper channel. At that point, there will likely be another PR to change the default settings. |
how do i add this to my bot...sorry noob here |
@Ilses i am giving this a run now! :D |
@mich3lamok thanks will do....btw been using this bot for days now and its amazing |
@carlanivans i am a lil bit confused about the: |
@mich3lam Once again, that's the part we haven't made public. Our bot has too many permissions on the server, so waiting on an admin to cut those or it will get abused. |
@Ilses Oh ahaha so i cannot really test it for now :< |
@carlanivans this actually stops the sniping from the setting.cs right ? these don't work anymore, i mean the ones in the bottom with coordinates |
@mich3lam ahhhh ok thanks maybe those coordinates are dry now......but still no solution for my bot not working after 30 mins |
I just added discord user login ability: 5andr0/PogoLocationFeeder@3724afa |
so with this we can actually use it now? @5andr0 |
@mich3lam i just manually go there and farm and use quick spin to get unbanned XD |
yes @mich3lam it's ready to use, just pull my sniper branch from https://github.com/5andr0/NecroBot.git |
@5andr0 ye i have already compiled everything localy.. |
@5andr0 is there any way to add and compile without visual studio? |
Use this server id: 206232715530338305 from PokemonGo Rare Hunting and channel high_iv_pokemon or rare_pokemon |
@5andr0 i wanted to test it |
i mean, it reads but the bot doesn't do anything with it |
pm me on discord please @mich3lam |
maybe make him snipe only for pokemon with the best skill sets? |
Sounds cool, I'm now in the discord group. How do I go about setting it up? Should I leave coordinates in the config.json for necrobot or remove them completely and leave "SnipeAtPokestops" as True? |
How to use it, i cant down it! |
wow this is awesome can't wait for the merge |
Pulled this into my bot, works great! Now if only I didn't have to restart the bot every 30 seconds. |
"SnipeLocationServer": "localhost", |
@5andr0 Thanks - seems to keep old sniping locations forever - 15 minutes remove doesnt seem to occur.? or maybe to long? |
guys wehere i need to put this item in ; ?? |
This reverts commit 606a207.
@jaskovic PogoLocationFeeder -> config.json |
Won't snipe pokemons with unknown iv
Hi, I was compiled the new branch of incasesensitive, no more sniper info from the console. |
@miraclesuki no idea, pm me on discord |
This works really well. Good job. Hope it gets merged. |
@5andr0 where to find you in discord? ^^ |
Hi. thanks for the work on this why does it scan locations without a selected pokemon? (eg. Missingto not included in snipe pokemon list, but Bot snipes locations with Missingto - doesnt find any - but shouldn't it not save the location data for unselected pokemon id?) |
help :( http://pastebin.com/b1t9Sbdn config.json necrobot |
When ever i add "SnipeAtPokestops": true, To necro bot config.json |
I've got NecroBot working and PogoLocationFeeder working, but can't connect them. My necrobot config file doesn't update with the server options. I've read that I have to "build branch here: https://github.com/5andr0/NecroBot/tree/sniper". Could someone explain how to do it or give some tips? |
See our wiki page for a configuration tutorial. |
I used the fork from @5andr0 before but it doesn't has the 30min fix included... Since I am lazy today I decided to give NecroBot a try again (still using prefork-modified^^). With @5andr0 's fork the Sniperfunction was working perfectly fine. After this got merged in I pulled the latest commit be2f597 and it rarely snipes even if the PogoLocationFeeder is getting massively filled ... Using the same settings I would argue its an setting-related. Haven't found out yet what the issue is :-/ but I guess it could be related to changes after this merge to sniper related tasks... |
@Ilses The tutorial says that my necrobot Config file should contain these: but it doesn't |
@Ilses I am on the latest version |
@Ilses Already on non-GPX here |
How exactly do I compile necrobot to use with this? |
waiting for @hungvinh |
When I download the source code and open the solution it doesn't load PokemonGo.RocketAPI and it says it's unavailable and I can't find it in the folders either. How do I fix that? Is it my VS? |
@nenko91 You need to download the API separately and put it in the FeroxRev folder. |
@mvegter197 Cheers, man! Been headbanging since yesterday over that. |
See for yourself: Image
The client connects to an open source server made by @Ilses and me:
https://github.com/5andr0/PogoLocationFeeder/tree/master/PogoLocationFeeder
Right now it is crawling new pokemon locations from the discord channel #sniping
and sending them via json to the client. This can be improved to be a pokevision scraper etc
There's a major bug in FarmPokestopsGPXTask.cs
where
while (pokestopList.Any())
is never true because pokestops are already @ cooldown because of UseNearbyPokestopsTask. So all the calls in the loop are never executed (or 1 in 100). That's why i had to move the SnipePokemonTask call out which is then called more often. So i added the MinDelayBetweenSnipes.More info on our wiki page: PogoLocationFeeder Wiki
Quick tutorial:
Can we find somebody to host the feeder so everybody can connect via ip+port?
Please help me to improve the feeder project. Todo: location database with continuous pokevision scraping. Or anything that helps to get locations.
Make sure you filled your PokemonToSnipe array: