Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional information egg hatched event #1386

Merged
merged 3 commits into from
Jul 30, 2016
Merged

Additional information egg hatched event #1386

merged 3 commits into from
Jul 30, 2016

Conversation

RoseFlunder
Copy link
Contributor

@RoseFlunder RoseFlunder commented Jul 29, 2016

Added additional information to egg hatched event (level, cp, iv) and changed the logging for this event accordingly.

Moreover the event and the egg status update event will use the EGG log level and is thus printed in dark yellow.

… changed the logging for this event accordingly.

Moreover the event will use the EGG log level and is printed in dark yellow to make it more visible.
@GoldSoulTheory1
Copy link

That's awesome. I was just thinking a few minutes ago what happens after the egg hatches. I know I've hatched a lot, no idea what came from them though.

@Sulvyr
Copy link

Sulvyr commented Jul 29, 2016

hi! Is any way to set a priority of eggs in incubator? Like 10km high priority then 5km and last 2km.

@mich3lam
Copy link
Contributor

Compiles great! thank you! :)

@RoseFlunder
Copy link
Contributor Author

@ifbatmanwasreal There is already a logic implemented which prefers "long" eggs for limited incubators:
var unusedEggs = (await session.Inventory.GetEggs()) .Where(x => string.IsNullOrEmpty(x.EggIncubatorId)) .OrderBy(x => x.EggKmWalkedTarget - x.EggKmWalkedStart) .ToList();
...
// Unlimited incubators prefer short eggs, limited incubators prefer long eggs
var egg = incubator.ItemId == ItemId.ItemIncubatorBasicUnlimited ? unusedEggs.FirstOrDefault() : unusedEggs.LastOrDefault();

@GoldSoulTheory1
Copy link

@RoseFlunder That's cool. I'm not too worried about which incubators are used. I'm wondering what Pokemon I get when the egg hatches.

…already associated with the log level EGG.

EggIncubatorStatusEvent now also use the EGG log level
@RoseFlunder
Copy link
Contributor Author

I merged the latest changes to resolve all conflicts

@NecronomiconCoding NecronomiconCoding merged commit ef1ca06 into NecronomiconCoding:master Jul 30, 2016
schnapster pushed a commit to schnapster/NecroBot that referenced this pull request Dec 8, 2016
Additional information egg hatched event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants